Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #322

Merged
merged 20 commits into from
Sep 18, 2023
Merged

Add more tests #322

merged 20 commits into from
Sep 18, 2023

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Sep 16, 2023

Ticket(s)

Description

This PR includes housekeeping, dependency updates and more tests. While adding tests I also fixed a few issues I found.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) and type annotations to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.

Legal Checklist

@mostafa mostafa linked an issue Sep 16, 2023 that may be closed by this pull request
@mostafa mostafa force-pushed the add-more-tests branch 6 times, most recently from 0fa6ba9 to 0957a31 Compare September 17, 2023 13:24
@mostafa mostafa merged commit f83a4b8 into main Sep 18, 2023
@mostafa mostafa deleted the add-more-tests branch September 18, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more tests
1 participant